Skip to content

feat: create federated log provider#3044

Open
voorepreethi wants to merge 6 commits intonewrelic:mainfrom
voorepreethi:fedLogsSetup
Open

feat: create federated log provider#3044
voorepreethi wants to merge 6 commits intonewrelic:mainfrom
voorepreethi:fedLogsSetup

Conversation

@voorepreethi
Copy link

Description

Please include a summary of the change and which issue is fixed (if relevant).

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

@maya-jha maya-jha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. How was testing done for this?
  2. Provide usage examples.

"newrelic_workflow": resourceNewRelicWorkflow(),
"newrelic_workload": resourceNewRelicWorkload(),
"newrelic_user": resourceNewRelicUser(),
"newrelic_federated_log_setup": resourceNewRelicFederatedLogSetup(),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use federated_logs here and elsewhere instead, this will become newrelic_federated_logs_setup


func resourceNewRelicAwsConnectionUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
// Update not yet supported for AwsConnectionEntity in the client
return resourceNewRelicAwsConnectionRead(ctx, d, meta)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we add it?

UpdateContext: resourceNewRelicFederatedLogPartitionUpdate,
DeleteContext: resourceNewRelicFederatedLogPartitionDelete,
Importer: &schema.ResourceImporter{
StateContext: schema.ImportStatePassthroughContext,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen if schema changes in API?

Comment on lines +231 to +235
return resourceNewRelicFederatedLogPartitionRead(ctx, d, meta)
}

func resourceNewRelicFederatedLogPartitionDelete(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
return nil

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants